Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop the Extension API Server reference from agones-allocator #1124

Merged
merged 2 commits into from
Oct 20, 2019
Merged

Drop the Extension API Server reference from agones-allocator #1124

merged 2 commits into from
Oct 20, 2019

Conversation

pooneh-m
Copy link
Contributor

@pooneh-m pooneh-m commented Oct 17, 2019 •
edited
Loading

agones-allocator is referencing allocation extension API and this change is removing the dependency by referencing the allocator lib directly.

Notes:

  • ClusterRole for agones-allocator is now expended to access secrets, nodes and game servers
  • The node game server counter is not synced with the counter used by game server controller and therefore the packed scheduling is not as accurate. (At this point packed or redistributed scheduling is not applicable for multi-cluster allocation as the destination cluster may not need the same scheduling setting as the origin cluster.)

#1018

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: ae6d86b7-aaf8-4fc4-9440-55c8bf42afe3

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@pooneh-m pooneh-m marked this pull request as ready for review October 17, 2019 23:45
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 2b7c03d1-5d40-42cc-b914-ed39093c21a0

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 0e0715a5-b8e3-40af-ae18-e71a5a9579ab

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1124/head:pr_1124 && git checkout pr_1124
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-0f9c8fa

roberthbailey
roberthbailey reviewed Oct 18, 2019
View reviewed changes
cmd/allocator/main.go Outdated Show resolved Hide resolved
cmd/allocator/main.go Outdated Show resolved Hide resolved
cmd/allocator/main.go Outdated Show resolved Hide resolved
cmd/allocator/main.go Outdated Show resolved Hide resolved
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: bafb3c2d-4937-49fe-9847-6606f6f846e9

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1124/head:pr_1124 && git checkout pr_1124
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-2b56a6d

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: ae2fe966-edf2-4b39-8f43-c0eedf4eeaf5

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1124/head:pr_1124 && git checkout pr_1124
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-dcfaa1f

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 31348804-1164-4f45-9a58-6e606b1b8b48

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1124/head:pr_1124 && git checkout pr_1124
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-bb765dc

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pooneh-m, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [pooneh-m,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot
Copy link

New changes are detected. LGTM label has been removed.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: ca0fe0ef-0729-4c87-bc7c-340b8e525dca

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1124/head:pr_1124 && git checkout pr_1124
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-cdc960b

@roberthbailey roberthbailey merged commit 4e3cf7f into googleforgames:master Oct 20, 2019
@markmandel markmandel added this to the 1.1.0 milestone Oct 22, 2019
@markmandel markmandel added the kind/cleanup Refactoring code, fixing up documentation, etc label Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roberthbailey roberthbailey roberthbailey approved these changes

Assignees

@roberthbailey roberthbailey

Labels
approved kind/cleanup Refactoring code, fixing up documentation, etc size/L
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
5 participants
@pooneh-m @agones-bot @google-oss-robot @roberthbailey @markmandel